Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the button's onclick window.open for replacement by target=_blank #226

Open
Carreau opened this issue Dec 13, 2024 · 0 comments · May be fixed by #231
Open

Review the button's onclick window.open for replacement by target=_blank #226

Carreau opened this issue Dec 13, 2024 · 0 comments · May be fixed by #231
Labels
enhancement New feature or request

Comments

@Carreau
Copy link
Collaborator

Carreau commented Dec 13, 2024

Problem

A number of buttons use an onclik window.open to open in a new window, while <a target='_blank'> exist for this purpose.

This is not optimal as a hover on link with target-blank tell you what it does, but not if there is an onclick handler; and create accessibility issues.

Proposed Solution

use <a>s ans style them like the buttons

Additional context

https://github.com/jupyterlite/jupyterlite-sphinx/pull/223/files#r1883631155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use more accessible visual elements instead of buttons agriyakhetarpal/jupyterlite-sphinx
1 participant
@Carreau