Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks are wrong if directly followed by punctuation #7541

Open
Zirunis opened this issue Dec 13, 2024 · 1 comment
Open

Hyperlinks are wrong if directly followed by punctuation #7541

Zirunis opened this issue Dec 13, 2024 · 1 comment

Comments

@Zirunis
Copy link

Zirunis commented Dec 13, 2024

Description

Jupyter Notebook seems to be doing some HTML sanitization, including detecting URLs and adding clickable hyperlinks. This is a great feature but it doesn't seem to be working entirely correctly.
I noticed that for this warning
The new embeddings will be initialized from a multivariate normal distribution that has old embeddings' mean and covariance. As described in this article: https://nlp.stanford.edu/~johnhew/vocab-expansion.html. To disable this, use mean_resizing=False
the hyperlink falsely contains the end of sentence period, leading to an invalid link.
Interestingly, note that github extracts the correct hyperlink just fine.

Reproduce

  1. Print a valid hyperlink directly followed by punctuation
  2. Click on the link
  3. URL contains punctuation, site doesn't exist

Expected behavior

If the last character is a period, it should be cut off. Other punctuation, like question marks, exclamation points, commas and semi-colons should probably also be cut off.

@Zirunis Zirunis added bug status:Needs Triage Applied to issues that need triage labels Dec 13, 2024
@andrii-i
Copy link
Contributor

Hi @Zirunis, thank you creating this issue. I was not able to reproduce this in Notebook v7.3.1. When I paste text you used into a notebook markdown cell, URL is identified and rendered properly, without the trailing space (please see the screenshot below). What version of the notebook are you using? Could you please try the same actions in Notebook v7.3.1?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants