You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Jupyter Notebook seems to be doing some HTML sanitization, including detecting URLs and adding clickable hyperlinks. This is a great feature but it doesn't seem to be working entirely correctly.
I noticed that for this warning The new embeddings will be initialized from a multivariate normal distribution that has old embeddings' mean and covariance. As described in this article: https://nlp.stanford.edu/~johnhew/vocab-expansion.html. To disable this, use mean_resizing=False
the hyperlink falsely contains the end of sentence period, leading to an invalid link.
Interestingly, note that github extracts the correct hyperlink just fine.
Reproduce
Print a valid hyperlink directly followed by punctuation
Click on the link
URL contains punctuation, site doesn't exist
Expected behavior
If the last character is a period, it should be cut off. Other punctuation, like question marks, exclamation points, commas and semi-colons should probably also be cut off.
The text was updated successfully, but these errors were encountered:
Hi @Zirunis, thank you creating this issue. I was not able to reproduce this in Notebook v7.3.1. When I paste text you used into a notebook markdown cell, URL is identified and rendered properly, without the trailing space (please see the screenshot below). What version of the notebook are you using? Could you please try the same actions in Notebook v7.3.1?
Description
Jupyter Notebook seems to be doing some HTML sanitization, including detecting URLs and adding clickable hyperlinks. This is a great feature but it doesn't seem to be working entirely correctly.
I noticed that for this warning
The new embeddings will be initialized from a multivariate normal distribution that has old embeddings' mean and covariance. As described in this article: https://nlp.stanford.edu/~johnhew/vocab-expansion.html. To disable this, use
mean_resizing=False
the hyperlink falsely contains the end of sentence period, leading to an invalid link.
Interestingly, note that github extracts the correct hyperlink just fine.
Reproduce
Expected behavior
If the last character is a period, it should be cut off. Other punctuation, like question marks, exclamation points, commas and semi-colons should probably also be cut off.
The text was updated successfully, but these errors were encountered: