Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activateById toggle side panel instead of expanding it #7534

Open
3 tasks done
brichet opened this issue Dec 5, 2024 · 1 comment
Open
3 tasks done

activateById toggle side panel instead of expanding it #7534

brichet opened this issue Dec 5, 2024 · 1 comment
Labels
Milestone

Comments

@brichet
Copy link
Collaborator

brichet commented Dec 5, 2024

Please answer the following questions for yourself before submitting an issue

  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository

Description

Using the shell function activateById on a side panel widget may result to the opposite behavior, if the widget was already opened.

It may be related to #7178.
AFAIU the PR, if the id is provided and the current widget has this ID (it is opened), the expand will collapse the panel.

Reproduce

Hard to reproduce, it needs a extension that provide a sidepanel, and which call the shell.activateById on this sidepanel when it opened.
See context to reproduce it.

Expected behavior

The sidepanel to remain opened.

Context

Found when testing jupyterlab_chat.
This line is used to ensure that the sidepanel is open, but the sidepanel is collapsed instead.

cc. @haok1402

@brichet brichet added bug status:Needs Triage Applied to issues that need triage labels Dec 5, 2024
@jtpio jtpio added this to the 7.3.x milestone Dec 6, 2024
@brichet
Copy link
Collaborator Author

brichet commented Dec 9, 2024

#7178 has been include to fix #7147.

But these changes have led to some unexpected behavior, as the table of contents is not initially intended to be hidden by the menu, in Jupyterlab.

My opinion is that this PR should be reverted, and the menu action changed upstream in Jupyterlab, to toggle the panel instead of only activate it.

@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants