Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures of 0.11.0 #108

Open
frenzymadness opened this issue Dec 17, 2024 · 2 comments
Open

Test failures of 0.11.0 #108

frenzymadness opened this issue Dec 17, 2024 · 2 comments

Comments

@frenzymadness
Copy link
Contributor

I'm trying to update jupyter-events in Fedora Linux to 0.11.0 but 4 tests are failing for me:

=========================== short test summary info ============================
FAILED tests/test_logger.py::test_emit - AssertionError: assert {'__metadata_...: 'blah', ...} == {'__metadata_...hi...
FAILED tests/test_logger.py::test_message_field - AssertionError: assert {'__metadata_...as seen', ...} == {'__metadata_...as...
FAILED tests/test_logger.py::test_nested_message_field - AssertionError: assert {'__metadata_...e': None, ...} == {'__metadata_...ge...
FAILED tests/test_logger.py::test_unique_logger_instances - AssertionError: assert {'__metadata_...: 'blah', ...} == {'__metadata_...hi...
========================= 4 failed, 45 passed in 1.87s =========================

All of the failures are caused by:

>       assert event_capsule0 == expected
E       AssertionError: assert {'__metadata_...: 'blah', ...} == {'__metadata_...hing': 'blah'}
E         
E         Omitting 4 identical items, use -vv to show
E         Left contains 1 more item:
E         {'taskName': None}
E         Use -v to get more diff

What might be causing this?

@Carreau
Copy link
Member

Carreau commented Dec 18, 2024

I think #100 might have pointed to the reason. Maybe we should either requires a more recent python-json-logger – in general I think those errors are fine (if you can mark them as so).

I may do a 0.11.1 soon (but I'm usually not the maintainer of this package).

@Carreau
Copy link
Member

Carreau commented Dec 18, 2024

#110 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants