Rename new ParameterizedTest attributes to avoid confusion

[marcphilipp]

With #3708 (PR #4045) adding argumentCountValidation to @ParameterizedTest, I feel like there is a bit lack of clarity for users about what requireArguments does compared to argumentCountValidation. Specifically, I think it's not very clear which of these applies to arguments within an argument set and which applies to argument sets, if that is even the right wording.

@marcphilipp since you worked on both PRs, what's your opinion on this?
Maybe, it'd make sense to rename requireArguments to requireArgumentSets and improve the docs? Or it's not that big of a deal. I'm not sure.

For context these are the two fields in @ParameterizedTest:

junit5/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTest.java

Lines 295 to 325 in 490e663

	/**
	* Configure whether at least one set of arguments is required for this
	* parameterized test.
	*
	* <p>Set this attribute to {@code false} if the absence of arguments is
	* expected in some cases and should not cause a test failure.
	*
	* <p>Defaults to {@code true}.
	*
	* @since 5.12
	*/
	@API(status = EXPERIMENTAL, since = "5.12")
	boolean requireArguments() default true;
	/**
	* Configure how the number of arguments provided by an {@link ArgumentsSource} are validated.
	*
	* <p>Defaults to {@link ArgumentCountValidationMode#DEFAULT}.
	*
	* <p>When an {@link ArgumentsSource} provides more arguments than declared by the test method,
	* there might be a bug in the test method or the {@link ArgumentsSource}.
	* By default, the additional arguments are ignored.
	* {@code argumentCountValidation} allows you to control how additional arguments are handled.
	* The default can be configured via the {@value ArgumentCountValidator#ARGUMENT_COUNT_VALIDATION_KEY}
	* configuration parameter (see the User Guide for details on configuration parameters).
	*
	* @since 5.12
	* @see ArgumentCountValidationMode
	*/
	@API(status = EXPERIMENTAL, since = "5.12")
	ArgumentCountValidationMode argumentCountValidation() default ArgumentCountValidationMode.DEFAULT;

Originally posted by @JonasJebing in #1477

Deliverables

• Rename one or both attributes to make their effect clearer

[marcphilipp]

Idea: keep argumentCountValidation and rename requireArguments to requireInvocations or requireAtLeastOneInvocation

[JonasJebing]

I like requireInvocations and requireAtLeastOneInvocation better than my requireArgumentSets idea 👍
Maybe I have a slight preference for the more explicit requireAtLeastOneInvocation

[marcphilipp]

Team decision: Rename ParameterizedTest.requireArguments to allowZeroInvocations (and change default to true)

[Anmavel]

Hi, can i work on this issue? :)

[juliette-derancourt]

Hey @Anmavel, I just assigned the issue to you! :)

[sormuras]

Have fun hacking @Anmavel !

[JonasJebing]

Team decision: Rename ParameterizedTest.requireArguments to allowZeroInvocations (and change default to true)

@marcphilipp I think there's a typo. Shouldn't it be "change default to false"?

junit5/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTest.java

Line 307 in c96feb2

boolean requireArguments() default true;

Edit: I just saw the PR, where we're changing the default to false. So, all good from that side IMO 👍