New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hash with link icon on external site headings #4447

Open

amritadesmet opened this issue Nov 26, 2024 · 1 comment

Labels

type: site 🌐

Contributor

amritadesmet commented Nov 26, 2024 •

edited by origami-z

Loading

Change to "URL has been copied", Replace hash with link icon. For some reason, Salt website is not using Mosaic's copy feature
https://github.com/jpmorganchase/mosaic/blob/e2821e10afa243c0ea7d720e1a7767a00f7ea5ac/packages/components/src/Markdown/AnchorHeading/index.tsx#L69-L89

Edit scroll to prevent jumping to section, below css should help

scroll-margin-top: calc(4rem + 20px);

The text was updated successfully, but these errors were encountered:

github-project-automation bot added this to Salt - Components, Patterns and Theming

github-project-automation bot moved this to Green in Salt - Components, Patterns and Theming

amritadesmet added the type: site 🌐 label

origami-z mentioned this issue

Add site heading link scroll top #4449

Draft

Contributor

origami-z commented Nov 26, 2024

Trying to use Tag for the copy action, too big...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment