Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are ReliefFeatures not supported? #36

Open
shehzan10 opened this issue May 24, 2017 · 2 comments
Open

Are ReliefFeatures not supported? #36

shehzan10 opened this issue May 24, 2017 · 2 comments

Comments

@shehzan10
Copy link
Contributor

I've been working with a a couple of models from https://www.citygml.org/samplefiles/

Both of these models use ReliefFeature, but the CityObject for this returns 0 for both getGeometriesCount() and getImplicitGeometryCount(), and has 0 child city objects.

In FZK Viewer, the object tree for these files shows the relief:ReliefFeature as having a child relief:TINRelief object. This TINRelief object does not appear in the CityObject tree.

All the other features of the models seem to be working well. Am I missing something here?

@shehzan10
Copy link
Contributor Author

I verified from here that ReliefComponent is not supported.

I guess my next question is how hard would it be to support this? Understanding why it hasn't been implemented could help my efforts if I try to implement support for it.

@jklimke
Copy link
Owner

jklimke commented Jul 4, 2017

I guess it hasn't been implemented simply because it was not needed up to now.

This decision was taken before i took the library over to github. But feel free to give the implementation a try. Do not forget to add a small test dataset and a corresponding test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants