Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom data source instead of users.timezone #32

Open
nyalex opened this issue Apr 22, 2020 · 1 comment
Open

Custom data source instead of users.timezone #32

nyalex opened this issue Apr 22, 2020 · 1 comment

Comments

@nyalex
Copy link

nyalex commented Apr 22, 2020

In my apps, we do not store the timezone in users.timezone. We have a separate database table that stores various account-level settings, the timezone being only one of them. I suspect that others have similar implementations, or at the very least, a different column even.

With that, I'd like to make a suggestion. instead of mandating that we use users.timezone as the source of the user's timezone, allow for a model to return this information that can be customizable. Perhaps look in the User Eloquent model for a method with a specific naming convention (e.g. getUserTimezone())?

I am happy to contribute when I can - if you agree with my thinking.

@jamesmills
Copy link
Owner

WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants