Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy to clipboard initial implementation #8

Closed
wants to merge 2 commits into from
Closed

Copy to clipboard initial implementation #8

wants to merge 2 commits into from

Conversation

renjithgr
Copy link
Contributor

@renjithgr renjithgr commented Jul 17, 2020 •
edited
Loading

@jamesgeorge007 jamesgeorge007 added the enhancement New feature or request label Jul 18, 2020
@jamesgeorge007 jamesgeorge007 linked an issue Jul 18, 2020 that may be closed by this pull request
implement copy to clipboard functionality #7
Open
@renjithgr renjithgr mentioned this pull request Jul 19, 2020
Closed
jamesgeorge007
jamesgeorge007 requested changes Jul 19, 2020
View reviewed changes
Copy link
Owner

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should be notified once he/she clicks the button. I would prefer a toast like implementation over the plain alert().

@jamesgeorge007
Copy link
Owner

Can we have the migration to Ace-Editor in another PR?

@renjithgr
Copy link
Contributor Author

I will close this PR for now since I realized copying to clipboard will interfere with the editor changes. I will raise a PR for ace editor first then implment the copy to clipboard on top of it.

@renjithgr renjithgr closed this Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement copy to clipboard functionality
2 participants
@renjithgr @jamesgeorge007