New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage pipeline is failing. #1386

Open

2 tasks done

Stevenjin8 opened this issue Dec 12, 2024 · 1 comment

Assignees

Labels

Contributor

Stevenjin8 commented Dec 12, 2024 •

edited

Loading

Its failing because the toolchain version of apt install llvm is different from the one use by rustc.

The solution is to use install the llvm-tools rustup component so that we do not rely on Ubuntu's llvm version to match rustc's.

TODO:

add the llvm-tools rustup component to build-tools image https://rust-lang.github.io/rustup/concepts/components.html Add rustup llvm toolchain tools#3091.
change the test-with-coverage.sh script to use rustup run <toolchain> llvm-xyz instead of llvm-xyz. Use rustup llvm tools #1387

The text was updated successfully, but these errors were encountered:

Stevenjin8 self-assigned this

Stevenjin8 mentioned this issue

Use rustup llvm tools #1387

Merged

Stevenjin8 added the area/testing label

Contributor Author

Stevenjin8 commented Dec 17, 2024

Both got merged and things work inside the container on my machine... but fail in actual CI. Hoping that the tests are just flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment