Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL and plpython #213

Open
ethervoid opened this issue Nov 28, 2016 · 1 comment
Open

REPL and plpython #213

ethervoid opened this issue Nov 28, 2016 · 1 comment

Comments

@ethervoid
Copy link

Hi!

We're using iPython as REPL for PlPython functions in Postgres. We have a PlPython function that creates and starts an iPython kernel.

With the 3.x version of iPython worked fine. I've been migrating it to the new Jupyter versions due to the big split and We've found some problems with the signal handler, more concretely [here] (https://github.com/ipython/ipykernel/blob/master/ipykernel/kernelbase.py#L245).

PLPython returns None when you try to get the signal handler for SIGINT but could occur in regular python too because get_signal could return None if the signal was not installed from Python. Maybe a check for None for the self. saved_sigint_handler could be a good idea?

What do you think? I was going to send a patch but first I want to be sure is treated as a possible bug

@takluyver
Copy link
Member

It certainly sounds worth adding a check. I guess if it's a non-Python handler, we just have to reset it to some default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants