Deprecate ipyparallel-specific code #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's moving to ipyparallel
Will allow ipyparallel subclassing to be cleaner
delay instantiation in order to show deprecation message
|
This should be ready to go. I'll merge in the next day or so unless I hear otherwise. |
minrk
changed the title
|
I changed my mind a little - I'll wait until we can ship ipyparallel 5.0 before releasing this one. Should be soon. |
|
ipyparallel 5.0 shipped, so this should be able to go in, now. |
| Run at the beginning of request handlers. | ||
| """ | ||
| md = super(IPythonKernel, self).init_metadata(parent) | ||
| # FIXME: remove ipyparallel-specific code |
There was a problem hiding this comment.
What's the plan for dealing with these?
There was a problem hiding this comment.
Going forward, these are provided by a subclass in ipyparallel. Removing these would be a breaking change, and would break ipyparallel < 5. We can consider dropping then in ipykernel 5 or 6.
|
Other than those things, 👍 |
add should_handle short-circuit method for implementing abort
minrk
force-pushed
the
deprecate-parallel
branch
from
7d771e0 to
3e94318
Compare
|
Comments/docstrings updated to address the comments. |
minrk
force-pushed
the
deprecate-parallel
branch
from
3e94318 to
07da04e
Compare
takluyver
added a commit
that referenced
this pull request
Feb 8, 2016
Deprecate ipyparallel-specific code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: ipython/ipyparallel#61
closes #17