feat(wallet-dashboard): add tx details state to the end of migration flow #4547
Conversation
evavirseda
added
the
wallet-dashboard
|
This pull request has been deployed to Vercel. Latest commit: c34de10 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-n76llxm4h.vercel.app |
| isTimelocked, | ||
| ); | ||
|
|
||
| const { totalNotOwnedStorageDepositReturnAmount } = summarizeMigratableObjectValues({ |
There was a problem hiding this comment.
something weird is happening here, the IOTA to be migrated do not correspond to those signed in the tx. Maybe this is a bit more logical, we can look at it in another task
There was a problem hiding this comment.
If resource repo is used to mint the NFT outputs than they also hold the balance of 1 Iota each so that is where the extra iota balance is probably coming from
There was a problem hiding this comment.
we are taking those IOTA into account, look here
| /> | ||
| )} | ||
| {isLoading ? ( | ||
| <LoadingIndicator text="Loading migration objects" /> |
There was a problem hiding this comment.
we could use skeleton instead of LoadingIndicator here, wdyt?
There was a problem hiding this comment.
Maybe its better to do it in another PR no?
There was a problem hiding this comment.
I'm working in this now 🙏
apps/wallet-dashboard/components/Dialogs/migration/MigrationDialog.tsx
Outdated
Show resolved
Hide resolved
|
This pull request has been deployed to Vercel. Latest commit: 178c4da ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-jk3krfwsk.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 3993027 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ce4okdf5y.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: a74342d ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-cijkpdw6i.vercel.app |
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
fixes #4508
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.