Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_gather #3010

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Fix test_gather #3010

merged 2 commits into from
Dec 19, 2024

Conversation

ESI-SYD
Copy link
Contributor

@ESI-SYD ESI-SYD commented Dec 16, 2024

Make getStackPointer as interface of the TargetInfo to generalize getSharedMemoryBase in gather op.

@ESI-SYD ESI-SYD linked an issue Dec 16, 2024 that may be closed by this pull request
@ESI-SYD ESI-SYD marked this pull request as draft December 16, 2024 02:52
@ESI-SYD ESI-SYD marked this pull request as ready for review December 17, 2024 03:12
@chengjunlu
Copy link
Contributor

The major difference of the lowering gather operation is intel::LLVM::getSharedMemoryBase.
We can make the function LLVM::intel::getStackPointer to be a interface of the TargetInfo.

Can we unify the lowering code to the upstream Triton?

@ESI-SYD
Copy link
Contributor Author

ESI-SYD commented Dec 17, 2024

The major difference of the lowering gather operation is intel::LLVM::getSharedMemoryBase. We can make the function LLVM::intel::getStackPointer to be a interface of the TargetInfo.

Can we unify the lowering code to the upstream Triton?

Changed in e100879

@whitneywhtsang
Copy link
Contributor

Please try to upstream these changes.

@chengjunlu
Copy link
Contributor

LGTM now. It worth for us to upstream the reasonable decoupling changes.

We can clean up the redundant lowering code as long as we use the LinearLayout widely. It help us to save the overhead in mergeing changes to downstream.

@ESI-SYD
Copy link
Contributor Author

ESI-SYD commented Dec 18, 2024

Please try to upstream these changes.

triton-lang/triton#5451

@ESI-SYD ESI-SYD merged commit fdab3bb into main Dec 19, 2024
5 checks passed
@ESI-SYD ESI-SYD deleted the yudong/2878 branch December 19, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UT] Fix test_gather
3 participants