Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container resources are not properly restored for out-of-sync containers. #917

Open
ppalucki opened this issue Nov 15, 2022 · 2 comments
Open

Comments

@ppalucki
Copy link
Contributor

Describe the bug

When I remove cri-rm cache (/var/lib/cri-rm/cache) and restart cri-rm the mechanism for restoring list of containers misses some information - one of them is the resources requests/limits because such information is provided by ListContainerResponse.

Expected behavior
When cache is removed or cri-resmgr is started for a first time - all the containers in cache have proper resources based on pod.spec.containers.resources.

To Reproduce

  1. Install cri-rm on some kubernetes worker node
  2. compare existing pods containers resource requests with those found in /var/lib/cri-resmgr/cache
 cat /var/lib/cri-resmgr/cache | jq '.Containers[].Resources'

all are empty

Environment
SLES, 5.3.18

Additional context
probably a limitation of ListContainerResponse (because resources info is not provider) in

func (m *resmgr) syncWithCRI(ctx context.Context) ([]cache.Container, []cache.Container, error) {

@ppalucki
Copy link
Contributor Author

@klihub Do you need more info?

@marquiz
Copy link
Contributor

marquiz commented Dec 23, 2022

@klihub @ppalucki is this now fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants