Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autodetection of cgroupv2 and proper container resource control using cgroupv2. #784

Open
klihub opened this issue Mar 2, 2022 · 0 comments

Comments

@klihub
Copy link
Contributor

klihub commented Mar 2, 2022

Describe the bug

cri-resmgr fails to properly adjust resources in container creation/update requests, if the node is using cgroup v2.

Expected behavior

cri-resmgr autodetects if cgroup v2 is in use and properly adjusts itself to control resources using entries in the unified cgroupv2 CRI resource field.

To Reproduce

  1. Enable a cgroup v2 on a node
  2. Configure kubelet using cri-resmgr as the CRI runtime, and for instance topology-aware policy
  3. Create a burstable or a guaranteed container.
  4. Observe the logs about where/to which CPUs cri-resmgr assigns containers.
  5. Observe actual pinning, or to be precise the lack of thereof. Containers are running on all CPUs.

Environment

Should not matter, as long as the kernel, the real runtime and kubelet are all cgroupv2 aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant