fix: graceful handling of 404 in github_actions_repository_oidc_subject_claim_customization_template #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te): graceful handling of 404 on read The resource github_actions_repository_oidc_subject_claim_customization_template would error when the associated repository was deleted. This change will gracefully remove the resource on 404 not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource github_actions_repository_oidc_subject_claim_customization_template would error when the associated repository was deleted.
This change will gracefully remove the resource on 404 not found.
Resolves #2482
Before the change?
Currently when running terraform destroy execution fails if the repository that has oidc customization outside terraform. The 404 is handled when querying the oidc customization itself, but not in the prior request to get the repository id.
After the change?
If the repository no longer exists then the github_actions_repository_oidc_subject_claim_customization_template resource will be removed from the state (if the repo no longer exists then the oidc customization cannot either).
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!