Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated repo collaborators to support ignoring teams #2481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Nov 28, 2024

Resolves #2470


Before the change?

  • Using a team slug for github_repository_collaborators would result in churn
  • There is no way to manage repository collaborators for an organization that has organization roles defined without specifying these teams as part of the github_repository_collaborators resource (which works but is technically incorrect).

After the change?

  • Using a team slug for github_repository_collaborators does not churn
  • You can use the team_ignore block on a github_repository_collaborators resource to ignore organization managed teams.
    • Due to the lack of flag in the GitHub API this can't be cheaply powered by a ignore_org_teams resource flag, as that would take multiple API calls and an increase in required permissions.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell force-pushed the fix-collaborators-churn branch from 1d433f2 to 636bac2 Compare November 28, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: team membership flaps constantly after release 6.4.0 apparently due to #2420
1 participant