Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong From implementation. #524

Open
gabrik opened this issue Jul 31, 2024 · 1 comment
Open

Wrong From implementation. #524

gabrik opened this issue Jul 31, 2024 · 1 comment

Comments

@gabrik
Copy link

gabrik commented Jul 31, 2024

Hi all,

I just noticed a crash on my application when calling if let Ok(mime: Mime) = x.try_into() beacuse of the unwrap() in: https://github.com/http-rs/http-types/blob/v2.12.0/src/mime/mod.rs#L131

I think TryFrom implementation would be nice to have as would avoid this kind of errors.

I know I can use the FromStr (that what I'm doing after I discovered the issue), but the I still think it is worth to have the TryFrom

I can come with a PR.

@gabrik gabrik changed the title Mime missing TryFrom implementation. Wrong From ~Mime missing TryFrom~ implementation. Jul 31, 2024
@gabrik gabrik changed the title Wrong From ~Mime missing TryFrom~ implementation. Wrong From implementation. Jul 31, 2024
@gabrik
Copy link
Author

gabrik commented Jul 31, 2024

Acutally, let me update this by changing the name. Current From implementation is wrong as it contains and unwrap that can fail.

So either it becomes a TryFrom or it can be removed as the FromStr is already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant