Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When spans are kept due to Dynsampler Keyspace exhaustion, note it on the spans #1306

Open
mterhar opened this issue Sep 3, 2024 · 1 comment
Labels
type: enhancement New feature or request

Comments

@mterhar
Copy link

mterhar commented Sep 3, 2024

Is your feature request related to a problem? Please describe.
Currently, when a trace is kept due to dynsampler keyspace exhaustion, it doesn't show in honeycomb.

Describe the solution you'd like
Include the rule that matched and the fact that keyspace was exhausted.

Describe alternatives you've considered
Make a "everything else" bucket for spans that match exhausted Keyspaces so they still get sampled a bit, even if it's not perfect.

Additional context

@mterhar mterhar added the type: enhancement New feature or request label Sep 3, 2024
@codeboten
Copy link
Contributor

Would adding a metric around keyspace exhaustion errors be a helpful thing to have here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants