Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Image Mixup, Non New Games Have 'New' Tag #1396

Open
Omay238 opened this issue Jan 17, 2024 · 6 comments · May be fixed by #2738
Open

Gallery Image Mixup, Non New Games Have 'New' Tag #1396

Omay238 opened this issue Jan 17, 2024 · 6 comments · May be fixed by #2738
Assignees
@JosiasAurel
Labels
bug Something isn't working low priority

Comments

@Omay238
Copy link
Contributor

Omay238 commented Jan 17, 2024

Describe the bug
Both happen in the gallery. Sometimes, games will have the wrong image, and it seems that the games at the top of the list always have the 'new' banner thing. I suspect the image issue is caused by some optimization somewhere, and the 'new' banner issue is probably because it's designed to work with sorting by date, and also it's designed to work with all games (none filtered out)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Gallery
  2. Search for something (I searched for all of my games)
  3. See items with 'new' banner on the top
  4. Scroll down, see items with wrong image

Expected behavior
Only new games have the new banner, games have the image that is assigned to them, not the image assigned to others.

Actual behavior
Any games at the top after searching have the 'new' banner, and images sometimes show up above the wrong games.

Screenshots

Screenshot 2024-01-17 at 4 19 59 PM
@Omay238 Omay238 added the bug Something isn't working label Jan 17, 2024
@Omay238
Copy link
Contributor Author

Omay238 commented Jan 17, 2024

Expected screen
Screenshot 2024-01-17 at 4 28 57 PM

@JosiasAurel JosiasAurel self-assigned this Jan 19, 2024
@JosiasAurel
Copy link
Contributor

the filtering issue is fixed since #1400
however I'm unable to reproduce the scenario where the images are incorrectly placed

@JosiasAurel
Copy link
Contributor

Expected screen Screenshot 2024-01-17 at 4 28 57 PM

where did you get this expected screen btw?

@Omay238
Copy link
Contributor Author

Omay238 commented Jan 19, 2024 •
edited
Loading

however I'm unable to reproduce the scenario where the images are incorrectly placed

you have to type fast and scroll down fast. then the wrong images are used.

Screen.Recording.2024-01-19.at.10.37.08.AM.mov

where did you get this expected screen btw?

i did the typing/scrolling slowly to get the right images, then used inspect to get rid of the 'new' labels

@JosiasAurel
Copy link
Contributor

@Omay238 what browser are you using here?

@Omay238
Copy link
Contributor Author

Omay238 commented Jan 19, 2024

Arc 1.26.0

@JosiasAurel JosiasAurel mentioned this issue Jun 3, 2024
Merged
@JosiasAurel JosiasAurel linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JosiasAurel JosiasAurel

Labels
bug Something isn't working low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

separate gallery game into its own component hackclub/sprig
3 participants
@leomcelroy @JosiasAurel @Omay238