Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantom Tiles happening when placing sprites with names longer than a character #1892

Open
29cmb opened this issue Jul 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@29cmb
Copy link
Member

29cmb commented Jul 4, 2024

Describe the bug
Creating a sprite with a name that starts with the name of another sprite creates phantom tiles

To Reproduce
Create a sprig project and create 2 items in the legend, w for winSpace, and wa for Wall
If I want to place the wa, instead of just placing the wall, it places a winSpace and a red square, the req square makes a new row or column of tiles which cannot be interacted with or placed on, generating phantom tiles

Expected behavior
Either WA should be placed just fine or an error should be given saying "Sprite names must be one character"

Actual behavior
Creates phantom tiles with no indication of something being wrong.

2024-07-04.08-20-22.mp4
@29cmb 29cmb added the bug Something isn't working label Jul 4, 2024
@BrightTheBackpack
Copy link
Member

I think that's just due to the nature of the map. Maps have a multi-line string of characters representing the bitmaps to be rendered. When the sprite name is longer than a character, "wa" gets added, but it gets parsed as "w" "a". I think having an error added is a good idea though

@29cmb
Copy link
Member Author

29cmb commented Jul 30, 2024

Yeah that is the issue, but it's not addressed which is the problem

@BrightTheBackpack
Copy link
Member

theres already errors when you set a bitmap to more than one character. how else do you suggest this to be adressed?

@29cmb
Copy link
Member Author

29cmb commented Jul 31, 2024

It should probably just not let you assign a bitmap to a multi-character name in the first place, as that error only appears when the run button is pressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants