Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve retry logic to only retry for appropriate HTTP error codes #861

Open
another-rex opened this issue Mar 15, 2024 · 8 comments · May be fixed by #1390
Open

Improve retry logic to only retry for appropriate HTTP error codes #861

another-rex opened this issue Mar 15, 2024 · 8 comments · May be fixed by #1390
Assignees
@VishalGawade1
Labels
good first issue Good for newcomers

Comments

@another-rex
Copy link
Collaborator

another-rex commented Mar 15, 2024 •
edited
Loading

Followup to #860 to only retry for appropriate HTTP codes.

I.e. Only retry on 500s, and not 400 codes
@github-actions GitHub Actions
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jul 18, 2024
@another-rex another-rex added good first issue Good for newcomers and removed stale The issue or PR is stale and pending automated closure labels Jul 18, 2024
@shashtag
Copy link

Hello @another-rex , I would like to work on this issue.

@VishalGawade1
Copy link

Is someone working on this issue? can I have it?

@another-rex
Copy link
Collaborator Author

No one is working on this at the moment, but there might be significant refactors coming to the request code as part of our V2 change. That is still a month or so away though, so plenty of time to get a quick fix in.

@VishalGawade1
Copy link

Thanks a lot for assigning it to me! I will update you soon :)

@VishalGawade1
Copy link

Hi @another-rex , I’ve updated the retry logic as discussed, retrying only on 500 errors. Would it be okay for me to raise a PR for this fix? Thanks!

@G-Rath
Copy link
Collaborator

G-Rath commented Nov 8, 2024

@VishalGawade1 yup if you've got a fix open a pr 🙂

@VishalGawade1 VishalGawade1 linked a pull request Nov 9, 2024 that will close this issue
Open
@VishalGawade1
Copy link

Hello @G-Rath , @another-rex ,
I have raised a PR, with all the necessary requirements. Please let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VishalGawade1 VishalGawade1

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Improve Retry Logic to Only Retry on Server-Side HTTP Errors VishalGawade1/osv-scanner
4 participants
@G-Rath @VishalGawade1 @shashtag @another-rex