Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Adding metadata in response #1325

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Feature: Adding metadata in response #1325

wants to merge 4 commits into from
+8 −6

Conversation

coolwednesday
Copy link
Contributor

@coolwednesday coolwednesday commented Dec 20, 2024 •
edited
Loading

Pull Request Template

Description:

Screenshot 2024-12-20 at 4 43 11 PM

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@Umang01-hash
Copy link
Contributor

Please also update the documentation and add tests.

@ccoVeille
Copy link
Contributor

Adding tests to control make sure how errors are reported would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipul-rawat vipul-rawat vipul-rawat left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting metadata in API repsonse
4 participants
@coolwednesday @Umang01-hash @ccoVeille @vipul-rawat