Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New experimental query: Java BigDecimal DOS #435

Closed
1 task done
tonghuaroot opened this issue Sep 22, 2021 · 8 comments
Closed
1 task done

New experimental query: Java BigDecimal DOS #435

tonghuaroot opened this issue Sep 22, 2021 · 8 comments
Labels
All For One Submissions to the All for One, One for All bounty

Comments

@tonghuaroot
Copy link

tonghuaroot commented Sep 22, 2021

Query

Relevant PR: github/codeql#6730

CVE ID(s)

Report

Directly incorporating user input into an BigDecimal Operation Function without validating the input
can facilitate DOS attacks. In these attacks, the server
will consume a lot of computing resources, A typical scenario is that the CPU usage rises to close to 100%.
This issue often occurs in scenarios that require scientific computing, such as e-commerce platforms and electronic payments.

  • Are you planning to discuss this vulnerability submission publicly? (Blog Post, social networks, etc). We would love to have you spread the word about the good work you are doing

Result(s)

@tonghuaroot tonghuaroot added the All For One Submissions to the All for One, One for All bounty label Sep 22, 2021
@anticomputer
Copy link
Contributor

@tonghuaroot what is the associated CVE (old or new) for this submission? A CVE-ID is required to submit an All For One bounty query as per: https://securitylab.github.com/bounties/

Create an issue using the all for one template and a detailed report on the class of vulnerabilities your query is intended to find. Pull requests without an accompanying issue cannot be considered. The issue should include details of any vulnerabilities found by your query, as a list of CVEs. To be considered, your query must find at least one CVE that was not previously found by an existing query, in a released version (older releases are also permitted) of an open source project that is actually used (no demo, training, vulnerable on purpose). Submissions without at least one result won't be considered. In case of a new CVE, don't create an issue until the coordinated disclosure process for those vulnerabilities is complete, because the issue will be publicly visible.

@tonghuaroot
Copy link
Author

Hi @anticomputer,

Thanks for your response.

I have found some results. I have submitted them to the owner of the corresponding open source software, but I still haven't applied for CVE. I want to know how I can submit this part of information to you?

@tonghuaroot
Copy link
Author

I will try to request CVE and then update this issue, Thanks.

@JarLob
Copy link
Contributor

JarLob commented Nov 18, 2021

Hi @tonghuaroot,
Is there any update?
Please note, that you may provide any historical CVE that could have been detected with your query. No need to find a new vulnerability.

@tonghuaroot
Copy link
Author

Hi @JarLob,

Thanks for your hint, Let me try to find this pattern in historical CVE.

@antonio-morales
Copy link
Contributor

Hi @tonghuaroot,

any update on this?

@ghsecuritylab
Copy link
Collaborator

Your submission is now in status Closed.

For information, the evaluation workflow is the following:
Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

@ghsecuritylab
Copy link
Collaborator

Your submission is now in status Closed.

For information, the evaluation workflow is the following:
Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
All For One Submissions to the All for One, One for All bounty
Projects
None yet
Development

No branches or pull requests

6 participants