Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression while scanning Ruby code #13103

Closed
deivid-rodriguez opened this issue May 10, 2023 · 3 comments
Closed

Performance regression while scanning Ruby code #13103

deivid-rodriguez opened this issue May 10, 2023 · 3 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@deivid-rodriguez
Copy link

I noticed that since (I think) CodeQL 2.13.0, our action to analyze Ruby code is taking much longer.

Here's a 3 minutes run using 2.12.6: https://github.com/dependabot/dependabot-core/actions/runs/4768651225/jobs/8478202528.

Vs a 35 minutes run using 2.13.0: https://github.com/dependabot/dependabot-core/actions/runs/4768852196/jobs/8478637429.

After pinning back to https://github.com/github/codeql-action/releases/download/codeql-bundle-20230418/codeql-bundle.tar.gz (bundling 2.12.7) at dependabot/dependabot-core#7275, it's fast again.

Not sure if this could be related to #12349, but that one seems older, so I went with a separate ticket. I also posted a comment at #13028, in case the fix could help here.

Thanks!

@aibaars
Copy link
Contributor

aibaars commented May 10, 2023

Thanks for reporting. We're looking into this!

@aeisenberg
Copy link
Contributor

aeisenberg commented May 10, 2023

We've identified the culprit and are working on a fix. Assigning to @erik-krogh who is doing the work.

@deivid-rodriguez
Copy link
Author

I just verified that this is fast again in the latest version, thanks so much for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants