A3-1-5: Exclude instantiated templates and compiler generated members

[lcartey]

Affected rules

• A3-1-5

Description

Exclude instantiated templates from this rule here:
https://github.com/github/codeql-coding-standards/blob/main/cpp/common/src/codingstandards/cpp/Class.qll#L184

Also exclude compiler generated members.

Example

[knewbury01]

there is no example, so it is a bit unclear what the goal is - based on the cited library location already specifying member functions that are not involved in instantiated templates

however, when looking at this rule perhaps this issue had something to do with this part of the rule not being constrained to avoid template instantiations here

all in all, I think the rule logic needs more work though and that/any feedback this issue was describing will be captured in this issue

[lcartey]

Apologies, I should have provided a permalink here, this was the line I meant we needed to change:

codeql-coding-standards/cpp/common/src/codingstandards/cpp/Class.qll

Line 195 in 7644032

TemplateOrTemplateClassMemberFunction() { isFromUninstantiatedTemplate(_) }