-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing information in json files compared to the advisory page #1580
Comments
Hey @Hritik14 thanks for reaching out with this! We're currently working on adding credits (and credit types) to the JSON files. Can you tell me about how this came to your attention? Was there something you wanted to do with credit information from the JSON files? |
Hello @KateCatlin! I do not think it is ideal to scrape the webpage for anything, instead if you could provide a structured source of all data present on the webpage, it would be great! |
Makes sense, thanks @Hritik14. I'll keep this thread updated when we launch! |
Hey @Hritik14 update on this– We did indeed ship our work to support different credit types on advisories. But due to technical reasons, displaying credit information in the JSON files would have made this epic 2-3x as much work, so we cut that part for now. I understand this is likely frustrating and I'm using this feedback to more highly prioritize getting credit information into JSON files in a future quarter. Leaving this issue open for others to chime in for support if desired! |
I'm missing support for this as well. I have some advisories that I want credited, which were imported from NVD mostly, but am unable to correctly update this information. |
For example:
The https://github.com/github/advisory-database/blob/5b6aa08e4edaca41f91dbe18cf8c6fd65cefe528/advisories/github-reviewed/2023/01/GHSA-c653-6hhg-9x92/GHSA-c653-6hhg-9x92.json JSON does not contain the "credit" information from GHSA-c653-6hhg-9x92
Reference: aboutcode-org/vulnerablecode#297 (comment) by @pombredanne
The text was updated successfully, but these errors were encountered: