Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSDate+DOSDate.h file not found #65

Open
geoffscottsf1 opened this issue Jan 27, 2018 · 2 comments
Open

NSDate+DOSDate.h file not found #65

geoffscottsf1 opened this issue Jan 27, 2018 · 2 comments

Comments

@geoffscottsf1
Copy link

The 1.0.5 release removes the NSDate+DOSDate.h file but does not remove the dependency on it in OZZipFile.m So a clean pod install on a new machine, for instance, causes a compile time error.

There may also still be a dependency on NSDate+CRC32.h but I didn't look further into things.

Rolling back to 1.0.4 worked. This should be fixed for future versions. Either the file(s) needs to be kept in the pull or the dependency needs to be removed.

@gianlucabertani
Copy link
Owner

This issue is irreproducible.

I created a single-view iOS app project from scratch, called it ObjZipApp, and added the following Podfile:

use_frameworks!

platform :ios, '10.0'
project 'ObjZipApp.xcodeproj'

target 'ObjZipApp' do
    platform :ios, '10.0'
    project 'ObjZipApp.xcodeproj'
    pod 'objective-zip', '1.0.5'
end

I then copied the content of test01_ZipAndUnzip from the Objective-Zip sources in the viewDidLoad event (removing asserts, of course). After a pod install, the app built successfully and the test executed correctly.

The files you name are present in version 1.0.5, they are even referenced explicitly in the podspec:

[...]
  # ――― Publich Headers ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― #

  s.public_header_files = ["Objective-Zip/OZZipFile.h", "Objective-Zip/OZZipFile+Standard.h", "Objective-Zip/OZZipFile+NSError.h",
                           "Objective-Zip/OZZipFileMode.h", "Objective-Zip/OZZipCompressionLevel.h", "Objective-Zip/OZZipException.h",
                           "Objective-Zip/OZZipWriteStream.h", "Objective-Zip/OZZipWriteStream+Standard.h",
                           "Objective-Zip/OZZipWriteStream+NSError.h", "Objective-Zip/OZZipReadStream.h",
                           "Objective-Zip/OZZipReadStream+Standard.h", "Objective-Zip/OZZipReadStream+NSError.h",
                           "Objective-Zip/OZFileInZipInfo.h", "Objective-Zip/Objective-Zip.h", "Objective-Zip/Objective-Zip+NSError.h",
                           "Objective-Zip/NSDate+DOSDate.h", "Objective-Zip/NSData+CRC32.h"]
[...]

You may have some problems with the project configuration, or maybe your CocoaPods version (or master repo cache) is out of date. Try updating it, then issue a pod repo update to update its cache, and finally reissue a pod install. This will ensure your sources and project configuration are correct.

Let me know if the problem persists.

@jflow: This test project also shows that Objective-Zip fully supports being built as a framework, by using the common use_frameworks! option. I guess you added your comment on issue #22 without even trying.

@geoffscottsf1
Copy link
Author

The issue was found on a new machine with fresh copies of the latest Xcode, cocoapods, and a pod install. It's certainly possible there was a hiccup somewhere that caused the issue, given what you write about the pod spec. But the file was not on the machine anywhere and the other files were.

If no one else is having problems, then this is no big deal. Just thought you should be aware of it, in case others find it, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants