-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support source-context resolution from multiple files #1112
Comments
This came up in getsentry/sentry#60236 We'd need to change how the candidates are looked up. Doesn't seem so hard to do but maybe I'm missing something: symbolicator/crates/symbolicator-native/src/symbolication/module_lookup.rs Lines 312 to 333 in 2474a74
Notably from |
Historically, only source-bundles contained sources for source-context. Nowadays, you can also have them in Portable PDBs, whether as embedded, or as links. In the future, other formats may follow.
In order to resolve source context as best as we can, we should not limit resolution to a single debug file that reports
has_sources() = true
but instead try to match each of them until a match is found. Alternatively, they should be combined. This resolution could be cached if needed.The text was updated successfully, but these errors were encountered: