feat(nuxt): Add deployment-platform flow with links to docs #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
s1gr1d
reviewed
Dec 18, 2024
Lms24
approved these changes
Dec 18, 2024
Comment on lines
+174
to
+180
| if (canImportSentryServerConfigFile) { | ||
| msg += `\n\nAfter building your Nuxt app, you need to ${chalk.cyan( | ||
| '--import', | ||
| )} the Sentry server config file.\n\nFor more info see: ${chalk.cyan( | ||
| 'https://docs.sentry.io/platforms/javascript/guides/nuxt/install/cli-import/#initializing-sentry-with---import', | ||
| )}`; | ||
| } |
There was a problem hiding this comment.
l: given that this is a pretty crucial step, I was thinking that we could make this a step that users have to confirm instead of showing this in the outro message.
So basically, print this message and make them confirm the step with an "Ok, I got it" or so. There's similar precedence for something like this in our source map wizard.
I'll leave this up to you though, so feel free to go with whatever you prefer.
| if (canImportSentryServerConfigFile) { | ||
| msg += `\n\nAfter building your Nuxt app, you need to ${chalk.cyan( | ||
| '--import', | ||
| )} the Sentry server config file.\n\nFor more info see: ${chalk.cyan( |
There was a problem hiding this comment.
l: Feel free to go with something else but I was a bit confused what I'd need to do at first.
Suggested change
| )} the Sentry server config file.\n\nFor more info see: ${chalk.cyan( | |
| )} the Sentry server config file when running your app.\n\nFor more info see: ${chalk.cyan( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now ask where users plan to deploy their app:
For Vercel and Netlify we configure top level import of the Sentry server config file and link to docs:
For other/none we instruct people at the end to
--importtheir Sentry server config file and link to docs:This also improves the handling when a user's nuxt config can not be read. Instead of exiting the wizard, we continue and instruct people how to manually add it (already existed, but we bailed immediately after instructing).
Closes: #739