Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pelican -lr not reloading on content changes in 4.10.2 on Windows 11 #3431

Open
mauricef opened this issue Dec 1, 2024 · 7 comments
Open
Labels

Comments

@mauricef
Copy link

mauricef commented Dec 1, 2024

  • [ x] I have read the Filing Issues and subsequent “How to Get Help” sections of the documentation.

  • [ x] I can reproduce this problem with stock/default settings file, theme, and sample content (as described in above “How to Get Help” sections of the documentation).

  • [ x] I have searched the issues (including closed ones) and believe that this is not a duplicate.

  • OS version and name: Windows 11 HOME

  • Python version: Python 3.12.4

  • Pelican version: 4.10.2

  • Link to theme: default

  • Links to plugins: default

Issue

I installed pelican 4.10.2[markdown] and ran the quickstart command and added a single article from the guide.

I run pelican -lr and editing the article does not cause an autoreload. If I downgrade to pelican 4.10.1, autoreload works as expected.

@mauricef mauricef added the bug label Dec 1, 2024
@justinmayer
Copy link
Member

I do not have access to any systems running Windows and thus cannot reproduce. I do not see much in the diff between 4.10.1 and 4.10.2 that would cause the described problem, but of course I cannot rule it out.

@MinchinWeb: Could you run a few quick tests and see if you can confirm the problem described here?

@MinchinWeb
Copy link
Contributor

Sure thing!

@mauricef , would you be able to run pip freeze and paste the contents (or a screenshot) as a comment here?

The drive you're watching, is it a local (i.e. attached to your computer) or network drive?

Lastly, to confirm, you're remembering to save your (post) file after you change it? (I've been bitten by this an embarrassingly high number of times...)

@mauricef
Copy link
Author

mauricef commented Dec 2, 2024

It looks like it's this change

If I override IGNORE_FILES in pelicanconf.py and set it back to

IGNORE_FILES": [".#*"]

Then the changes are detected

@justinmayer
Copy link
Member

Good to know. Do you have any idea why this change has that effect? In theory, it should only ignore invisible files and folders.

@mauricef
Copy link
Author

mauricef commented Dec 2, 2024

I'm not sure, I'll play around with it some more, I see it gets translated to via fnmatch.translate and passed to watchfiles as a filter, I'll see if I can isolate the issue outside pelican.

@MinchinWeb It's a local drive, I have confirmed I'm saving the file and here is pip freeze

anyio==4.6.2.post1
blinker==1.9.0
docutils==0.21.2
feedgenerator==2.1.0
idna==3.10
Jinja2==3.1.4
Markdown==3.7
markdown-it-py==3.0.0
MarkupSafe==3.0.2
mdurl==0.1.2
ordered-set==4.1.0
pelican==4.10.2
Pygments==2.18.0
python-dateutil==2.9.0.post0
pytz==2024.2
rich==13.9.4
six==1.16.0
sniffio==1.3.1
tzdata==2024.2
Unidecode==1.3.8
watchfiles==1.0.0

@MinchinWeb
Copy link
Contributor

@mauricef Thanks! I'll need some more time to dig into it, but I'll post back here

@Jonakemon
Copy link

Jonakemon commented Dec 4, 2024

@MinchinWeb running into the same issues on Ubuntu 22.04 with Pelican 4.10.2. The issue - I think - lies in 1edca55. It's the only meaningful commit between the two patch versions that could be the cause of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants