Replies: 3 comments 6 replies
-
|
Thanks for posting a discussion about homepage here on GitHub. Homepage now uses a fancy new AI tool thanks to our friends at Glime, so the answer below is the AI bot's attempt to answer your question. If you feel it's sufficient you can mark the answer and close this post, otherwise feel free to leave it open of course! Thanks for using Homepage! ❤️ To provide an accurate response to your question regarding the commit Typically, changes may be reverted for several reasons, such as:
To understand the specific reason for the reversion of the change in question, you would need to look at the commit message associated with the revert, any related issues or pull requests, or discussions among the project maintainers. If the project is hosted on GitHub, you can typically find this information by looking at the commit history, checking the linked issues or pull requests, or reviewing the discussion in the project's issues or discussions sections. If you have further questions or need more detailed information, I recommend reaching out to the project maintainers directly or looking for an explanation in the project's documentation or community forums. This comment was generated by Glime. |
Beta Was this translation helpful? Give feedback.
-
|
This discussion has been automatically closed due to inactivity. See our contributing guidelines for more details. |
Beta Was this translation helpful? Give feedback.
-
|
Issue still exists and the AI bot was less than helpful... @shamoon? |
Beta Was this translation helpful? Give feedback.
-
|
It is not fixed and the response of the AI is completely useless. The problem is very easy to reproduce: Create a minimal homepage with a Load the website using curl or some other tool that just gets the initial HTML: Expected: Actual: The HTML contains the default title: Only when you view the HTML in a browser with JavaScript enabled, the Before 2f89b12 the static HTML also was fine. |
Beta Was this translation helpful? Give feedback.
-
|
What a pleasant reply. As I said, the change was to fix something else and I don’t really remember now but basically it was a trade-off, maybe I can trace it back. But anyway, the fact that the page requires an initial load like that doesn’t seem to be a problem for most… |
Beta Was this translation helpful? Give feedback.
-
|
Well, it's not a major problem, but I'd still argue that it should be looked into / improved. E.g. when you paste a link to the homepage to, let's say WhatsApp, Slack, Discord, ..., which show a little preview / description of the link, you always just get 'Homepage' as the description, never your intended title, as these bots do not evaluate JS. Same for search engines. Your homepage is always indexed under the generic title 'Homepage' instead of your own title. |
Beta Was this translation helpful? Give feedback.
-
|
If all this is about is the title that’s probably fine to change, and maybe you could’ve just said that earlier? |
Beta Was this translation helpful? Give feedback.
-
|
It's about all the properties that are used during the initial buildup of the static HTML, i.e. every variable that occurs in the diff of 2f89b12, hence the (technical) report. |
Beta Was this translation helpful? Give feedback.
-
Description
Since
2f89b12
the initial HTML does not respect the settings values anymore, because
settingsis empty initially.Why was this reverted?
homepage version
v0.9.2 (af16956)
Installation method
Docker
Configuration
No response
Container Logs
No response
Browser Logs
No response
Troubleshooting
Beta Was this translation helpful? Give feedback.
All reactions