Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freecodecamp.org/news/ dark mode theme #828

Open
fatihcaliss opened this issue Feb 23, 2024 · 4 comments · May be fixed by #942
Open

freecodecamp.org/news/ dark mode theme #828

fatihcaliss opened this issue Feb 23, 2024 · 4 comments · May be fixed by #942
Labels
type: feature request

Comments

@fatihcaliss
Copy link

fatihcaliss commented Feb 23, 2024 •
edited
Loading

I currently use a Google extension to enable dark mode for articles on /news in freeCodeCamp =>
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More. However, I would prefer not to rely on an extension for this feature. Could you consider implementing a native dark mode theme for freeCodeCamp news?

Describe the solution you'd like

I would like to use the theme mode selected in my freeCodeCamp account settings for the /news extension.

Describe alternatives you've considered

If feasible, these pages could default to the system theme color (dark or light) for the user's operating system.

Additional context

No response
@naomi-lgbt naomi-lgbt transferred this issue from freeCodeCamp/freeCodeCamp Feb 28, 2024
@a2937 a2937 mentioned this issue Jul 26, 2024
Closed
2 tasks
@ahmaxed
Copy link
Member

ahmaxed commented Aug 2, 2024

The toggle feature needs to satisfy the following requirements.

  • The theme toggle should be within a menu item.
  • The menu item should look and function similar to the one on learn
  • The the default theme selection should be similar to learn where the system theme is taken into account.

@a2937
Copy link
Member

a2937 commented Aug 2, 2024

What else should be visible in the menu or is the dark theme toggle the only menu item?

@ahmaxed
Copy link
Member

ahmaxed commented Aug 5, 2024

Initially the theme switcher should be sufficient for this pr.
Adding the search functionality in mobile would be next.
Then we could experiment with adding the forum and curriculum buttons in the menu as well.

@a2937 a2937 linked a pull request Aug 5, 2024 that will close this issue
Open
2 tasks
@ahmaxed ahmaxed mentioned this issue Sep 1, 2024
Closed
@ghost
Copy link

ghost commented Oct 20, 2024 •
edited by ghost
Loading

This is a big omission, I hope it will be included as soon as possible. Also, why not use a demo link in PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(UI): create night mode freeCodeCamp/news
feat(UI): create a dark mode toggle
4 participants
@raisedadead @ahmaxed @a2937 @fatihcaliss