Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration guide for ThemeData.indicatorColor deprecation #11481

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Migration guide for ThemeData.indicatorColor deprecation #11481

merged 4 commits into from
Dec 12, 2024
+87 −1

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Dec 10, 2024 •
edited
Loading

Related to flutter/flutter#155072
PR deprecating ThemeData.indicatorColor flutter/flutter#160024

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 10, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit d65f0ec):

https://flutter-docs-prod--pr11481-deprecate-indicatorcolor-mdpvhcfo.web.app

@TahaTesser TahaTesser marked this pull request as ready for review December 10, 2024 13:34
@TahaTesser TahaTesser requested review from sfshaza2, parlough and a team as code owners December 10, 2024 13:34
@TahaTesser TahaTesser marked this pull request as draft December 10, 2024 13:35
@TahaTesser TahaTesser mentioned this pull request Dec 10, 2024
Open
9 tasks
sfshaza2
sfshaza2 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Please go ahead and remove this PR from draft mode and land.

@sfshaza2 sfshaza2 added the st.RFM Ready to merge or land label Dec 10, 2024
@sfshaza2
Copy link
Contributor

I'm landing this, as the (quiet) 3.7 release happened yesterday.

@sfshaza2 sfshaza2 marked this pull request as ready for review December 12, 2024 20:56
@sfshaza2
Copy link
Contributor

/gcbrun

1 similar comment
@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2 sfshaza2 merged commit 9a82e91 into flutter:main Dec 12, 2024
9 checks passed
@Piinks
Copy link
Contributor

Piinks commented Dec 18, 2024

Please do not merge migration guides before the actual change lands. Thank you!
@TahaTesser maybe we should mark these as a draft going forward to prevent this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

Assignees
No one assigned
Labels
st.RFM Ready to merge or land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TahaTesser @flutter-website-bot @sfshaza2 @Piinks