Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple HTTP logic from User and Permission Resources. #17

Open
Marak opened this issue Jul 17, 2012 · 2 comments
Open

Decouple HTTP logic from User and Permission Resources. #17

Marak opened this issue Jul 17, 2012 · 2 comments

Comments

@Marak
Copy link

Marak commented Jul 17, 2012

Before a public release we should completely decouple the User and Permission resources from any HTTP specific logic.

The User and Permission resources should be part of a unified front / repository with other re-usable resources.

There is no reason this refactor should break any downstream dependencies.

Medium priority.

@indexzero
Copy link
Member

+1 to decoupling, but why separate the resources and the routes into different repos? It's all pure Javascript and this set of resources works well together to create an identify service (users, permissions, and orgs). Logically grouping resources together in this fashion makes the parts easier to digest.

I do however, think we should be able to disable the routes when attaching as a plugin. Often you don't want any, or some of the routes, but still want app.resources.User

@Marak
Copy link
Author

Marak commented Aug 22, 2012

Reference: cli-users issue #5

https://github.com/flatiron/http-users/blob/master/lib/http-users/user/core.js#L38
https://github.com/flatiron/cli-users/blob/master/lib/properties.js

Duplication of schema definitions across interfaces will cause mismatched schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants