Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for nodes with parent ids. #27

Open
faubulous opened this issue Feb 28, 2024 · 0 comments
Open

Add unit test for nodes with parent ids. #27

faubulous opened this issue Feb 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@faubulous
Copy link
Owner

When multiple inheritance is used, it is not sufficient that the node id just contains the URI of the resource. VS Code will throw an error when trying to insert a node with the same id multiple times in the tree.

The problem is a risk for the user experience and to prevent regressions in future versions there should be a unit test for this: the parent id should always be included in the node id.

As a side effect that would make the implementation of the the getParent method much easier as the URI is already encoded in the id.

@faubulous faubulous added the enhancement New feature or request label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant