Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CTRL key combinations don't work on the commit popup #2438

Open
Huliiiiii opened this issue Dec 1, 2024 · 1 comment
Open

Some CTRL key combinations don't work on the commit popup #2438

Huliiiiii opened this issue Dec 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Huliiiiii
Copy link

Huliiiiii commented Dec 1, 2024

To Reproduce
Steps to reproduce the behavior:

  1. Bind CTRL-Enter to commit, CTRL-i to open_commit_editor
  2. Open commit popup
  3. Press CTRL-Enter
  4. Insert new line
  5. Press CTRL-i
  6. Insert 4 spaces

Expected behavior
CTRL-Enter should do commit and CTRL-i should open editor

Screenshots
If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

  • OS/Distro + Version: Ubuntu 24.04.1 LTS
  • GitUI Version gitui nightly 2024-11-29 ()
  • Rust version: 1.82

Additional context
Add any other context about the problem here.

@Huliiiiii Huliiiiii added the bug Something isn't working label Dec 1, 2024
@stephenmartindale
Copy link

I noticed this, too, and am sad. I instinctively hit ctrl+enter to try to commit – every time – and wanted to make that work (instead of ctrl+d which is the default.)

For the record, the RON configuration to change the binding that I tested was:

(
  commit: Some(( code: Enter, modifiers: "CONTROL")),
)

When configured with the above, the gitui user interface does actually draw the symbols for ctrl+enter on the commit dialog's "do commit" button but pressing ctrl+enter is interpreted as if only enter was pressed: it types a new-line instead of performing the commit.

(gitui versions: nightly 2024-12-07 & nightly 2024-08-10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants