Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises(queen-attack): consider removing test for negative row/col, and support u3 fields #223

Open
ee7 opened this issue Mar 5, 2023 · 0 comments · May be fixed by #335
Open

exercises(queen-attack): consider removing test for negative row/col, and support u3 fields #223

ee7 opened this issue Mar 5, 2023 · 0 comments · May be fixed by #335
Assignees

Comments

@ee7
Copy link
Member

ee7 commented Mar 5, 2023

The valid range for row and col is from 0-7 inclusive, so it doesn't spark joy to test negative inputs, require input validation, and require the init method to take signed integer parameters.

Follow-up to:

@ee7 ee7 self-assigned this Sep 20, 2023
@ee7 ee7 linked a pull request Sep 21, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant