Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-mesh-lite espnow deleting peers after send (AEGHB-770) #112

Open
vinicius-smartme opened this issue Aug 9, 2024 · 2 comments
Open

Comments

@vinicius-smartme
Copy link

Description

After calling the esp_mesh_lite_espnow_send to send an espnow message, the esp-mesh-lite removes the peer. There is no documentation or rationale for such action.

The peer deletion is here:

if (!IS_BROADCAST_ADDR(peer_addr)) {

Problem

Unjustified peer deletion causes overhead to the user, that needs to re-add the peer after every send.

Proposed solution

Either remove the peer deletion or document the rationale/need.

@github-actions github-actions bot changed the title esp-mesh-lite espnow deleting peers after send esp-mesh-lite espnow deleting peers after send (AEGHB-770) Aug 9, 2024
@tswen
Copy link
Contributor

tswen commented Aug 12, 2024

Thank you for pointing out this issue, we will improve it as soon as possible.

@tswen
Copy link
Contributor

tswen commented Aug 22, 2024

Hello, the new mesh lite component has been updated, and the peer will no longer be deleted in esp_mesh_lite_espnow_send. At the same time, an API to delete the peer after sending is added: esp_mesh_lite_espnow_send_and_del_peer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants