New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading comments DataGenerator #183

Open

lucaslaurent04 opened this issue Sep 26, 2024 · 1 comment

Collaborator

lucaslaurent04 commented Sep 26, 2024

Wrong types in phpdoc:

$field_descriptor is an array
$lang is string|null

equal/lib/equal/data/DataGenerator.class.php

Lines 15 to 17 in 325f177

    
                * @param string    $field              Field name. 
        
                * @param string    $field_descriptor   Field descriptor. 
        
                * @param string    $lang               Lang code of the language in which the value must be generated (for multilang fields).

Collaborator Author

lucaslaurent04 commented Sep 26, 2024

The comment on $field_descriptor does not add any information and mislead on the type, why was it added ?

lucaslaurent04 mentioned this issue

Fix misleading comments #195

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment