Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component-lookup #20799

Open
chancancode opened this issue Nov 22, 2024 · 1 comment
Open

Remove component-lookup #20799

chancancode opened this issue Nov 22, 2024 · 1 comment

Comments

@chancancode
Copy link
Member

I am talking about this https://github.com/emberjs/ember.js/blob/main/packages/%40ember/-internals/views/lib/component_lookup.ts

As far as I can tell, it doesn't do anything anymore and haven't for a very long time. Yet we kept the code around and registered it into every application for no reason. That being said it seems to be available through Ember.ComponentLookup (as in import Ember from 'ember';) and the fact that it is registered means it can also be looked up. So straight-up removing the code may cause error in the real world, even though the code doesn't do anything useful anymore. (e.g. in ember-test-helper: https://github.com/emberjs/ember-test-helpers/blob/cbbadbe0b44f6d989990375e300422e8a0a50210/addon/src/-internal/build-registry.ts#L103-L105)

Probably should go around addressing any known consumers and then do an intimate deprecation cycle. Alternatively I suppose it could just piggy back on the deprecation for the component layout resolution thing, though they really aren't related (they used to, when overriding this actually worked).

@kategengler
Copy link
Member

import Ember from 'ember'; itself is slated for deprecation (doesn't solve this completely, but worth noting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants