Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the edit pencil for this app #957

Open
jenweber opened this issue Sep 9, 2021 · 2 comments
Open

Enable the edit pencil for this app #957

jenweber opened this issue Sep 9, 2021 · 2 comments

Comments

@jenweber
Copy link
Contributor

jenweber commented Sep 9, 2021

In the guides, we have an edit pencil at the top of each page. This helps contributors participate. We'd like to add that to this app.

This feature is already supported, and I think we just need to configure it.

@sdahlbac
Copy link

sdahlbac commented Oct 11, 2021

I started looking at this, but I suspect that the functionality you are talking about is:

https://github.com/empress/guidemaker/blob/3c2fb9e3dac0764a36ea617d970e828aa62a52ba/README.md?plain=1#L85
and used here:
https://github.com/ember-learn/guidemaker-ember-template/search?q=sourceRepo

but as far as I can tell, the deprecation-app is not using the guidemaker nor the guidemaker-ember-template.

So, is the right course of action to copy in the functionality from there, or pull in guidemaker et al?

@sdahlbac
Copy link

@jenweber what is your take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants