-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write missing deprecation guides #893
Comments
I think also |
That’s correct. In practice it can probably share most of the prose with that globals deprecation, you mostly experience that as a special case of the globals access deprecation |
I will work on the following: Ember.Component.reopen |
@Glarregle Awesome, thank you! |
I have a PR open that creates placeholder files for all these deprecations. We still need volunteers to fill in all the details in each deprecation guide. See #954 @Glarregle if my PR is merged before yours, please feel free to delete any of my descriptions and fill them with your own writeup. All I did was make the files and copy-paste the deprecation message into them, and we want to provide better guidance than what I copied in. Thank you! |
@Glarregle I discovered that the tagName deprecation already exists: https://deprecations.emberjs.com/v3.x/#toc_ember-built-in-components-legacy-arguments so this one does not need a new writeup. |
Hi, @fannyvanrell and myself would like to work on |
@bartocc @fannyvanrell Thank you, I think we do need help with providing details for https://deprecations.emberjs.com/v3.x#toc_ember-env-old-extend-prototypes. Can you also fix the typo in the |
Hi again. We'd like to go for |
@bartocc @fannyvanrell I updated the description to list your names. |
Hi everyone!
We noticed some missing deprecation guides when doing housekeeping in preparation for 4.0.
Assign yourself one of the deprecations below and let's get this done :)
What to do
Deprecations
Ember.Component.reopen
ember.component.reopen
Passing tagName to LinkTo
ember.link-to.tag-name
Passing disabledWhen to LinkTo
ember.link-to.disabled-when
Old deprecate method imports
old-deprecate-method-paths
Deprecate without
for
ember-source-deprecation-without-for
Deprecate without
since
ember-source-deprecation-without-since
EXTEND_PROTOTYPES
ember-env.old-extend-prototypes
Class-based template compilation plugins
template-compiler.registerPlugin
The text was updated successfully, but these errors were encountered: