Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search index duplicates for paths ember/2.x and 2.x #212

Open
mansona opened this issue Oct 27, 2018 · 1 comment
Open

Fix search index duplicates for paths ember/2.x and 2.x #212

mansona opened this issue Oct 27, 2018 · 1 comment

Comments

@mansona
Copy link
Member

mansona commented Oct 27, 2018

Currently there is an "alias" for ember deprecations that removes the need for project dynamic segment in the url. If you go to https://emberjs.com/deprecations/ember/v2.x it will have the same content as https://emberjs.com/deprecations/v2.x

This results in duplicate indexes for the Ember project deprecations.

We can solve this in a number of ways.

  • we should consider creating a redirect for https://emberjs.com/deprecations/v2.x to always include the project in the url. This will help with SEO duplicate content issues
  • we could use the "ignorePaths" functionality of ember-cli-deploy-prember-algolia to ignore projectless urls

Once we solve this problem we can remove this defensive programming implementation: https://github.com/ember-learn/deprecation-app/blob/master/app/templates/components/search-result.hbs#L1

@kennethlarsen
Copy link
Member

👋 @mansona - is this still relevant? If so could you give me a quick intro on Discord on the best way to solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants