Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid blobSupported detection #68

Open
krzbor opened this issue Apr 25, 2019 · 6 comments · May be fixed by #69
Open

Invalid blobSupported detection #68

krzbor opened this issue Apr 25, 2019 · 6 comments · May be fixed by #69

Comments

@krzbor
Copy link

krzbor commented Apr 25, 2019

The problem is the line:
blobSupported = new Blob (['ä']). size === 2; // Check if Blob constructor supports ArrayBufferViews
Check This and This
If the character encoding is Windows-1250, then blobSupported is FALSE!
@jimmywarting
Copy link
Contributor

could we change ['ä'] to ['\u00e4'] maybe?

@krzbor
Copy link
Author

krzbor commented May 1, 2019

Now it is working!
I checked on FF, Chrome, Edge.
I am asking you to introduce this amendment to blob.js.

jimmywarting added a commit to jimmywarting/Blob.js that referenced this issue May 1, 2019
@jimmywarting
change blobDetect support
468b1dd 
closes eligrey#68 
problem with other encoding formats
@jimmywarting jimmywarting linked a pull request May 1, 2019 that will close this issue
Open
@jimmywarting
Copy link
Contributor

Created a PR...

But why don't you switch to utf8?
Using any other then utf8 seems just ... well ... unwise?

http://codel10n.com/why-utf8-is-best-encoding-for-your-customers/

@krzbor
Copy link
Author

krzbor commented May 2, 2019

The WEB application was created many years ago. Its improvement is quite complex.

@krzbor
Copy link
Author

krzbor commented May 11, 2019

Will the change be introduced to the official version of blob.js? I am using jsPDF, which uses blob.js.

@jimmywarting
Copy link
Contributor

eligrey is not responseable for any npm package, you should contact the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change blobDetect support jimmywarting/Blob.js
2 participants
@jimmywarting @krzbor