Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to bundle renderer code #713

Open
timfish opened this issue Jun 15, 2021 · 2 comments
Open

Add option to bundle renderer code #713

timfish opened this issue Jun 15, 2021 · 2 comments
Labels
✨ enhancement New feature or request

Comments

@timfish
Copy link

timfish commented Jun 15, 2021

It's recommended that Electron renderers have nodeIntegration: false and contextIsolation: true and this means no access to require. This in turn means that it's currently not possible to create a fiddle that uses dependencies in the renderer which is quite a limitation.

@erickzhao erickzhao added the ✨ enhancement New feature or request label Jun 15, 2021
@codebytere
Copy link
Member

@timfish can you elaborate on this a bit more? would it not be possible for you to use contextBridge to pass over what you need?

@timfish
Copy link
Author

timfish commented Jun 18, 2021

I help maintain @sentry/electronand when developers open GitHub issues it would be great to say "modify this fiddle to show us what's not working". There are quite a few ways to use and configure Electron and fiddle is a great way to offer up some starting points for bug reports.

However, this isn't possible with any library that requires running in the isolated renderer context as there's no way to have dependencies in the isolated renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants