Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when npm is not installed in PATH #193

Open
jschlade opened this issue May 3, 2019 · 3 comments
Open

Error when npm is not installed in PATH #193

jschlade opened this issue May 3, 2019 · 3 comments

Comments

@jschlade
Copy link

jschlade commented May 3, 2019

Seeing this error:

📦 Packaging current Fiddle...

Error: Could not find npm. Fiddle requires Node.js and npm to compile packages. Please visit https://nodejs.org to install Node.js and npm.

On Windows 10 x64. Using Fiddle app 0.6.0 with Electron v5.0.0
NodeJS installed to C:\Program Files\nodejs but not on path.

In Fiddle console I see this error below.

Any ideas?

Thanks

app.15fac660.js:2044 Fetch Types: Updating Monaco types with [email protected]
app.15fac660.js:252 getIsNpmInstalled: "where.exe npm" failed. Error: Command failed: where.exe npm
INFO: Could not find files for the given pattern(s).



    at ChildProcess.exithandler (child_process.js:299)
    at ChildProcess.emit (events.js:182)
    at maybeClose (internal/child_process.js:962)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:251)
getIsNpmInstalled @ app.15fac660.js:252
@malept
Copy link
Member

malept commented May 4, 2019

Fiddle assumes that Node/NPM is in PATH. As a workaround, you should add it.

@felixrieseberg opinions on adding an optional setting to specify the location of NPM? Alternatively, we could update the error verbiage to mention adding Node/NPM to PATH.

@jschlade
Copy link
Author

jschlade commented May 4, 2019

It's usually good practice to not depend on something to be in the PATH to work. This is the way old applications used to work. Not something as new and slick as Fiddle.

Fiddle doesn't have NodeJS built in? If so why not add what is needed to Fiddle directly?

Thanks

@malept
Copy link
Member

malept commented May 4, 2019

NPM is kind of a big dependency to bundle with Fiddle.

@malept malept changed the title Could not find npm. Fiddle requires Node.js and npm to compile packages. npm not installed in PATH Feb 21, 2020
@malept malept changed the title npm not installed in PATH Error when npm is not installed in PATH Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants