Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UX for expired PAT for Gist publishing #1549

Open
erickzhao opened this issue Feb 21, 2024 · 2 comments
Open

Better UX for expired PAT for Gist publishing #1549

erickzhao opened this issue Feb 21, 2024 · 2 comments
Labels
area:gist ✨ enhancement New feature or request

Comments

@erickzhao
Copy link
Member

When a GitHub PAT expires, we pop up a dialog that says that the auth was invalid. To remedy this, the user needs to manually sign out in the settings afterwards and generate a new token.

As a UX improvement, we should redirect to the settings prompt as an option in the dialog, or at least clear the invalid token.

@erickzhao erickzhao added area:gist ✨ enhancement New feature or request labels Feb 21, 2024
@Santhoshmani1
Copy link
Contributor

The current warning popup is based on the showWarningDialogue.

Screenshot 2024-04-15 175557

  • The problem with the dialogue popup is the messageOptions props button field are defined as String[].
  • As a result, we can't toggle the settings panel or can't perform any other operation to the user actions.

@Santhoshmani1
Copy link
Contributor

Santhoshmani1 commented Apr 15, 2024

  • We can show a toast when the user's Github access token is expired. The toast will be more user-friendly when compared to the current showWarningDialogue .
  • Here is a possible solution that will help users to quickly navigate to the settings menu with the help of Toast, in order to redirect to settings & remove their expired github token.

Screenshot 2024-04-15 184932

Let me know your suggestions / alternatives. I am happy to contribute & will send a pull request to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gist ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants