Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent focus indicators throughout Fiddle #1085

Open
carolstran opened this issue May 26, 2022 · 5 comments
Open

Inconsistent focus indicators throughout Fiddle #1085

carolstran opened this issue May 26, 2022 · 5 comments
Labels
good first issue Good for newcomers ✨ enhancement New feature or request

Comments

@carolstran
Copy link

👋🏼 While tabbing around, I noticed that the focus indicators are inconsistent:

  • Text inputs with the bp3-input class have a default blue outline
  • Some input elements have a background-color: @foreground-2; style applied on focus (which I'm guessing is meant to change the outline)
  • Other focusable elements (like checkboxes) have an additional white outline
  • Buttons don't have focus indicators  #1084

I've opened a separate issue for the buttons as this is a more severe accessibility issue, but the rest are more of a matter of styling and preference 🤷🏼‍♀️

Screenshot from the settings page for reference:

@erickzhao erickzhao added the ✨ enhancement New feature or request label May 26, 2022
@codebytere codebytere added the good first issue Good for newcomers label May 27, 2022
@kirtanchandak
Copy link

Can I work on this issue ?

@BlackHole1
Copy link
Member

BlackHole1 commented Sep 17, 2022

Can I work on this issue ?

@kirtanchandak Sure.

@kirtanchandak
Copy link

Hey, where is the settings page in electron website ?

@erickzhao
Copy link
Member

@kirtanchandak this is not the repository for the electron website

@nitinmadelyn
Copy link

nitinmadelyn commented Apr 14, 2023

@codebytere Can i take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants